1.9: fix prerelease -> prerelease upgrades + dep updates #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vikaspotluri123
commented
Aug 15, 2018
vikaspotluri123
commented
- allow upgrades from prerelease -> prerelease (i.e. Ghost 2.0.0-rc.1 -> Ghost 2.0.0-rc.2)
- Dependency upgrades
kirrg001
reviewed
Aug 15, 2018
lib/utils/version-from-zip.js
Outdated
| if (err.message.match(/No valid versions found/) && semver.major(currentVersion) !== semver.major(pkg.version)) { | ||
| // CASE: you are on v2 prerelease, and want to upgrade to the next prerelease | ||
| if (err.message.match(/No valid versions found/) && | ||
| (semver.major(currentVersion) !== semver.major(pkg.version) || semver.prerelease(pkg.version)) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
I'm not sure what changed in eslint to require only the bin folder to be globbed 😕 I tested that the other folders were being linted by adding a syntax error to a file, and everything else is being picked up properly 🤷♂️ |
|
You have jumped to a major version of eslint? |
|
Yes, since the migration guide didn't seem to have any changes that would impact the CLI |
no issue The following packages have (partially) been held back: got - got v9 drops support for node v6 so we have to stay on got v8 rxjs - had migration issues for us in past upgrade attempts cli-table3 - the release on github is 0.5.0; not upgrading to be safe yargs - only upgraded semver minor since 1.9 is an important release validator - not upgrading for now
no issue - Updated edgecase logic to allow eg. Ghost 2.0.0-rc.1 to Ghost 2.0.0-rc.2 - Added tests to ensure e.g. Ghost 2.0.0-rc.1 to Ghost 2.0.0. - Previously, attempting to update ghost when in a prerelease could cause the CLI to incorrectly determine your instance is up to date
no issue eslint was complaining that no files matched bin, so updated the command to use the bin/* glob
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.