Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(extension): default should be value not key #935

Merged
merged 2 commits into from May 29, 2019
Merged

fix(extension): default should be value not key #935

merged 2 commits into from May 29, 2019

Conversation

ErisDS
Copy link
Member

@ErisDS ErisDS commented May 27, 2019

  • inquirer expects that the default you give it is the value, not the key, when it is a choice

@ErisDS
fix(extension): default should be value not key
41cd85d 
- inquirer expects that the default you give it is the value, not the key, when it is a choice
@coveralls
Copy link

coveralls commented May 27, 2019 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 42d47eb on ErisDS-patch-1 into d110a2a on master.

@acburdine acburdine added this to the 1.10.1 milestone May 29, 2019
@acburdine acburdine self-assigned this May 29, 2019
@acburdine acburdine merged commit b8401ec into master May 29, 2019
@acburdine acburdine deleted the ErisDS-patch-1 branch May 29, 2019 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acburdine acburdine acburdine approved these changes

Assignees

@acburdine acburdine

Labels
None yet
Projects
None yet
Milestone
1.10.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ErisDS @coveralls @acburdine