🐷 💄 Tiny theme-related improvements (#8532)

refs #8530

- display theme name for non-fatal errors
- minor wording tweak
- remove duplicate lodash require
- use the shiny new calculated property syntax

core/server/themes/active.js

@@ -21,7 +21,6 @@ var _ = require('lodash'),
     themeConfig = require('./config'),
     config = require('../config'),
     engine = require('./engine'),
-    _ = require('lodash'),
     // Current instance of ActiveTheme
     currentActiveTheme;
 

core/server/themes/to-json.js

@@ -19,8 +19,9 @@ module.exports = function toJSON(name, checkedTheme) {
         themeResult = packages.filterPackages(toFilter, settingsCache.get('active_theme'));
     } else {
         // If we pass in a gscan result, convert this instead
-        toFilter = {};
-        toFilter[name] = themeList.get(name);
+        toFilter = {
+            [name]: themeList.get(name)
+        };
 
         themeResult = packages.filterPackages(toFilter, settingsCache.get('active_theme'));
 

core/server/translations/en.json

@@ -107,7 +107,7 @@
             "themehandler": {
                 "missingTheme": "The currently active theme \"{theme}\" is missing.",
                 "invalidTheme": "The currently active theme \"{theme}\" is invalid.",
-                "themeHasErrors": "The currently active theme has errors, but theme still works."
+                "themeHasErrors": "The currently active theme \"{theme}\" has errors, but will still work."
             }
         },
         "utils": {