Skip to content

Commit

Permalink
Added 'bulk-email' tag to bulk messages sent with mailgun
Browse files Browse the repository at this point in the history
no issue

- helps distinguish bulk vs transactional email when both are using the same mailgun account
  • Loading branch information
kevinansfield committed Nov 15, 2019
1 parent 5fd2b7f commit 90f61d1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/server/services/bulk-email/index.js
Expand Up @@ -55,7 +55,7 @@ module.exports = {

if (bulkEmailConfig && bulkEmailConfig.mailgun && bulkEmailConfig.mailgun.tag) {
Object.assign(messageData, {
'o:tag': bulkEmailConfig.mailgun.tag

This comment has been minimized.

Copy link
@naz

naz Nov 15, 2019

Member

@kevinansfield Think it would be useful to always keep this tag on the emails that are being sent? Or was it intentional to assign it whenever there is some other tag configured already?

This comment has been minimized.

Copy link
@kevinansfield

kevinansfield Nov 19, 2019

Author Contributor

Good catch, I'd missed the outer conditional on the tag config. It's probably useful to always have this tag on emails sent via the bulk email service.

'o:tag': [bulkEmailConfig.mailgun.tag, 'bulk-email']
});
}

Expand Down

0 comments on commit 90f61d1

Please sign in to comment.