Skip to content

Commit

Permalink
setup/three fixes
Browse files Browse the repository at this point in the history
refs #5315
- adds call to loadServerNotifications so that notifications are loaded after setup
- fixes user invite so that you can't invite someone with the same email as you created the owner with
  • Loading branch information
acburdine committed Aug 10, 2015
1 parent 1751daa commit a428bfc
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 6 deletions.
17 changes: 13 additions & 4 deletions core/client/app/controllers/setup/three.js
Expand Up @@ -3,8 +3,12 @@ import DS from 'ember-data';

export default Ember.Controller.extend({
notifications: Ember.inject.service(),
two: Ember.inject.controller('setup/two'),

errors: DS.Errors.create(),
users: '',

ownerEmail: Ember.computed.alias('two.email'),
usersArray: Ember.computed('users', function () {
var users = this.get('users').split('\n').filter(function (email) {
return email.trim().length > 0;
Expand All @@ -17,11 +21,12 @@ export default Ember.Controller.extend({
return validator.isEmail(user);
});
}),
validateUsers: Ember.computed('usersArray', function () {
var errors = [];
validateUsers: Ember.computed('usersArray', 'ownerEmail', function () {
var errors = [],
self = this;

this.get('usersArray').forEach(function (user) {
if (!validator.isEmail(user)) {
if (!validator.isEmail(user) || user === self.get('ownerEmail')) {
errors.push({
user: user,
error: 'email'
Expand Down Expand Up @@ -115,6 +120,7 @@ export default Ember.Controller.extend({
invitationsString = successCount > 1 ? 'invitations' : 'invitation';

notifications.showAlert(successCount + ' ' + invitationsString + ' sent!', {type: 'success', delayed: true});
self.send('loadServerNotifications');
self.transitionTo('posts.index');
}
});
Expand All @@ -130,7 +136,10 @@ export default Ember.Controller.extend({
}
});
}
},
skipInvite: function () {
this.send('loadServerNotifications');
this.transitionTo('posts.index');
}
}
});

4 changes: 2 additions & 2 deletions core/client/app/templates/setup/three.hbs
Expand Up @@ -14,6 +14,6 @@
<button {{action 'invite'}} class="btn btn-default btn-lg btn-block {{buttonClass}}">
{{buttonText}}
</button>
{{#link-to "posts" class="gh-flow-skip"}}
<button class="gh-flow-skip" {{action "skipInvite"}}>
I'll do this later, take me to my blog!
{{/link-to}}
</button>

0 comments on commit a428bfc

Please sign in to comment.