Consistent event names

no issue - rename event to `server.stop` - rename event to `server.start` - we are using the dot notation
TryGhost · Apr 15, 2018 · b2a8165 · b2a8165
1 parent 63642fd
commit b2a8165
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/core/server/ghost-server.js b/core/server/ghost-server.js
@@ -94,7 +94,7 @@ GhostServer.prototype.start = function (externalApp) {
         self.httpServer.on('connection', self.connection.bind(self));
         self.httpServer.on('listening', function () {
             debug('...Started');
-            common.events.emit('server:start');
+            common.events.emit('server.start');
             self.logStartMessages();
             resolve(self);
         });
@@ -115,7 +115,7 @@ GhostServer.prototype.stop = function () {
             resolve(self);
         } else {
             self.httpServer.close(function () {
-                common.events.emit('server:stop');
+                common.events.emit('server.stop');
                 self.httpServer = null;
                 self.logShutdownMessages();
                 resolve(self);

diff --git a/core/server/services/themes/index.js b/core/server/services/themes/index.js
@@ -19,7 +19,7 @@ module.exports = {
         debug('init themes', activeThemeName);
 
         // Register a listener for server-start to load all themes
-        common.events.on('server:start', function readAllThemesOnServerStart() {
+        common.events.on('server.start', function readAllThemesOnServerStart() {
             themeLoader.loadAllThemes();
         });
 

diff --git a/core/server/services/url/UrlService.js b/core/server/services/url/UrlService.js
@@ -44,7 +44,7 @@ class UrlService {
         UrlService.cacheRoute('/subscribe/', {});
 
         // Register a listener for server-start to load all the known urls
-        common.events.on('server:start', (() => {
+        common.events.on('server.start', (() => {
             debug('URL service, loading all URLS');
             this.loadResourceUrls();
         }));

diff --git a/core/test/utils/index.js b/core/test/utils/index.js
@@ -933,7 +933,7 @@ startGhost = function startGhost(options) {
             .then(function () {
                 customRedirectsMiddleware.reload();
 
-                common.events.emit('server:start');
+                common.events.emit('server.start');
                 return ghostServer;
             });
     }