Skip to content

Commit

Permalink
Checked null & undefined in settings migration (#10609)
Browse files Browse the repository at this point in the history
no-issue

This is to make sure we catch all falsy cases of values.
  • Loading branch information
allouis committed Mar 13, 2019
1 parent 02c56e9 commit ca16b19
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ module.exports.up = (options) => {
}

// @NOTE: null or undefined were obviously intended to be false
if (entry.value === 'null' || entry.value === 'undefined') {
if (entry.value === null || entry.value === undefined || entry.value === 'null' || entry.value === 'undefined') {
const value = 'false';
common.logging.info(`Setting ${entry.key} to ${value} because it was ${entry.value}`);

Expand Down

0 comments on commit ca16b19

Please sign in to comment.