Fixed ghost admin error when missing theme folder.

closes #6368 - Add test to recreate the error in the static theme middleware. - Updated static theme middleware to not error if missing theme folder.
TryGhost · Jan 23, 2016 · cdc98dc · cdc98dc
1 parent 57ae36a
commit cdc98dc
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 4 deletions.
diff --git a/core/server/middleware/static-theme.js b/core/server/middleware/static-theme.js
@@ -11,10 +11,14 @@ function isBlackListedFileType(file) {
 }
 
 function forwardToExpressStatic(req, res, next) {
-    express.static(
-        path.join(config.paths.themePath, req.app.get('activeTheme')),
-        {maxAge: utils.ONE_YEAR_MS}
-    )(req, res, next);
+    if (!req.app.get('activeTheme')) {
+        next();
+    } else {
+        express.static(
+            path.join(config.paths.themePath, req.app.get('activeTheme')),
+            {maxAge: utils.ONE_YEAR_MS}
+        )(req, res, next);
+    }
 }
 
 function staticTheme() {

diff --git a/core/test/unit/middleware/static-theme_spec.js b/core/test/unit/middleware/static-theme_spec.js
@@ -65,4 +65,24 @@ describe('staticTheme', function () {
             done();
         });
     });
+
+    it('should not error if active theme is missing', function (done) {
+        var req = {
+                url: 'myvalidfile.css',
+                app: {
+                    get: function () { return undefined; }
+                }
+            },
+            activeThemeStub,
+            sandbox = sinon.sandbox.create();
+
+        activeThemeStub = sandbox.spy(req.app, 'get');
+
+        staticTheme(null)(req, null, function (reqArg, res, next2) {
+            /*jshint unused:false */
+            sandbox.restore();
+            next.called.should.be.false;
+            done();
+        });
+    });
 });