Skip to content

Commit

Permalink
Changed email model statuses in schema
Browse files Browse the repository at this point in the history
- Renames were done as that suits how emails would be handled by the bulk email handler
- These statuses are only for internal representation of the state and don't represent what happens to emails delivery-wise
- There is no need for 'sent' status as emails are "never done" and stats wold be checked for stats field would be used to check on details of the status
  • Loading branch information
naz committed Nov 7, 2019
1 parent b1d436e commit d0e8561
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions core/server/data/schema/schema.js
Expand Up @@ -385,8 +385,8 @@ module.exports = {
type: 'string',
maxlength: 50,
nullable: false,
defaultTo: 'sending',
validations: {isIn: [['pending', 'sending', 'sent', 'failed']]}
defaultTo: 'pending',
validations: {isIn: [['pending', 'submitting', 'submitted', 'failed']]}
},
error: {type: 'string', maxlength: 2000, nullable: true},
stats: {type: 'text', maxlength: 65535, nullable: true},
Expand Down
2 changes: 1 addition & 1 deletion core/test/unit/data/schema/integrity_spec.js
Expand Up @@ -19,7 +19,7 @@ var should = require('should'),
*/
describe('DB version integrity', function () {
// Only these variables should need updating
const currentSchemaHash = 'c4aac02dea06860a40932b1c128073e3';
const currentSchemaHash = 'ffc16afc9264ba20a0d8346387c163fb';
const currentFixturesHash = 'b1787330f042f3954d73c43aa8bfa915';

// If this test is failing, then it is likely a change has been made that requires a DB version bump,
Expand Down

0 comments on commit d0e8561

Please sign in to comment.