Removed post only fields from pages

- As we introduced email_subject and send_email_when_published for post responses we don't want to return them for pages
TryGhost · Nov 5, 2019 · d471001 · d471001
1 parent d5aa384
commit d471001
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/core/server/api/canary/utils/serializers/output/pages.js b/core/server/api/canary/utils/serializers/output/pages.js
@@ -12,15 +12,15 @@ module.exports = {
 
         if (models.meta) {
             frame.response = {
-                pages: models.data.map(model => mapper.mapPost(model, frame)),
+                pages: models.data.map(model => mapper.mapPage(model, frame)),
                 meta: models.meta
             };
 
             return;
         }
 
         frame.response = {
-            pages: [mapper.mapPost(models, frame)]
+            pages: [mapper.mapPage(models, frame)]
         };
     }
 };
diff --git a/core/server/api/canary/utils/serializers/output/utils/mapper.js b/core/server/api/canary/utils/serializers/output/utils/mapper.js
@@ -75,6 +75,15 @@ const mapPost = (model, frame) => {
     return jsonModel;
 };
 
+const mapPage = (model, frame) => {
+    const jsonModel = mapPost(model, frame);
+
+    delete jsonModel.email_subject;
+    delete jsonModel.send_email_when_published;
+
+    return jsonModel;
+};
+
 const mapSettings = (attrs, frame) => {
     url.forSettings(attrs);
     extraAttrs.forSettings(attrs, frame);
@@ -126,6 +135,7 @@ const mapMember = (model, frame) => {
 };
 
 module.exports.mapPost = mapPost;
+module.exports.mapPage = mapPage;
 module.exports.mapUser = mapUser;
 module.exports.mapTag = mapTag;
 module.exports.mapIntegration = mapIntegration;