Removed more unused fields from Admin API v2 response

refs #10438 - these fields are not used - no need to expose them in v2 - we will either remove them in the next major or use them for new features (will see)
TryGhost · Feb 13, 2019 · f8b62a0 · f8b62a0
1 parent a3e7a7b
commit f8b62a0
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 7 deletions.
diff --git a/core/server/api/v2/utils/serializers/output/utils/clean.js b/core/server/api/v2/utils/serializers/output/utils/clean.js
@@ -21,7 +21,7 @@ const tag = (attrs, frame) => {
     // Already deleted in model.toJSON, but leaving here so that we can clean that up when we deprecate v0.1
     delete attrs.parent_id;
 
-    // Extra properties removed from v2
+    // @NOTE: unused fields
     delete attrs.parent;
 
     return attrs;
@@ -36,10 +36,7 @@ const author = (attrs, frame) => {
         delete attrs.status;
 
         // Extra properties removed from v2
-        delete attrs.accessibility;
-        delete attrs.locale;
         delete attrs.tour;
-        delete attrs.visibility;
 
         // We are standardising on returning null from the Content API for any empty values
         if (attrs.twitter === '') {
@@ -65,19 +62,20 @@ const author = (attrs, frame) => {
         }
     }
 
+    // @NOTE: unused fields
+    delete attrs.visibility;
+    delete attrs.accessibility;
+    delete attrs.locale;
     delete attrs.ghost_auth_id;
 
     return attrs;
 };
 
 const post = (attrs, frame) => {
     if (localUtils.isContentAPI(frame)) {
-        delete attrs.locale;
-
         // @TODO: https://github.com/TryGhost/Ghost/issues/10335
         // delete attrs.page;
         delete attrs.status;
-        delete attrs.visibility;
 
         // We are standardising on returning null from the Content API for any empty values
         if (attrs.twitter_title === '') {
@@ -100,6 +98,8 @@ const post = (attrs, frame) => {
         }
     }
 
+    delete attrs.locale;
+    delete attrs.visibility;
     delete attrs.author;
 
     return attrs;

diff --git a/core/test/acceptance/old/admin/utils.js b/core/test/acceptance/old/admin/utils.js
@@ -25,12 +25,17 @@ const expectedProperties = {
         .keys()
         // by default we only return html
         .without('mobiledoc', 'plaintext')
+        .without('visibility')
+        .without('locale')
         // always returns computed properties: url, comment_id, primary_tag, primary_author
         .without('author_id').concat('url', 'primary_tag', 'primary_author')
     ,
     user: _(schema.users)
         .keys()
+        .without('visibility')
         .without('password')
+        .without('accessibility')
+        .without('locale')
         .without('ghost_auth_access_token')
         .without('ghost_auth_id')
     ,

diff --git a/core/test/regression/api/v2/admin/utils.js b/core/test/regression/api/v2/admin/utils.js
@@ -22,12 +22,17 @@ const expectedProperties = {
         .keys()
         // by default we only return html
         .without('mobiledoc', 'plaintext')
+        .without('visibility')
+        .without('locale')
         // always returns computed properties: url, comment_id, primary_tag, primary_author
         .without('author_id').concat('url', 'primary_tag', 'primary_author')
     ,
     user: _(schema.users)
         .keys()
+        .without('visibility')
         .without('password')
+        .without('accessibility')
+        .without('locale')
         .without('ghost_auth_access_token')
         .without('ghost_auth_id')
     ,