Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Members chart shows flat growth line for (GMT - X) timezones #12083

Closed
rishabhgrg opened this issue Jul 27, 2020 · 4 comments
Closed

Members chart shows flat growth line for (GMT - X) timezones #12083

rishabhgrg opened this issue Jul 27, 2020 · 4 comments
Assignees
@kevinansfield
Labels
affects:admin Anything relating to Ghost Admin affects:api Affects the Ghost API bug [triage] something behaving unexpectedly p2:major [triage] Bugs which we'll fix soon

Comments

@rishabhgrg
Copy link
Contributor

rishabhgrg commented Jul 27, 2020 •
edited

Issue Summary

If the site's timezone is set to any value before GMT/UTC, i.e. ( GMT - X ) timezones, the members chart in Admin incorrectly shows flatline with total number of current members since the start of date range, which is not the correct representation.

chart-flat

The 106 new members added in this date range should have been reflected in the chart correctly as growth instead of flat line.

To Reproduce

  1. Change the Site timezone to any (GMT - X) timezone in Settings -> General in Ghost Admin
  2. Make sure you have new members added to site in the selected date range
  3. The members chart on top will incorrectly show a flat line since start of range, instead of upward curve on date new members were added in that range.

Technical details:

  • Database: SQLite/Mysql
@rishabhgrg rishabhgrg added the bug [triage] something behaving unexpectedly label Jul 27, 2020
@ErisDS ErisDS added affects:admin Anything relating to Ghost Admin members labels Jul 27, 2020
@ErisDS ErisDS added the p2:major [triage] Bugs which we'll fix soon label Aug 3, 2020
@sonyamann
Copy link

Hi, is there an ETA on the fix for this? Support sent me to this GitHub issue.

@iamscottcab iamscottcab mentioned this issue Aug 28, 2020
Closed
3 tasks
@matthanley matthanley added affects:api Affects the Ghost API members and removed email labels Oct 2, 2020
@ceohockey60
Copy link

Hi there, any update on the progress of this bug? Would appreciate an ETA. Thanks!

iamscottcab pushed a commit to iamscottcab/Ghost that referenced this issue Nov 19, 2020
Fixed member chat flat growth for GMT -X Timezones.
5c2d2dd 
refs TryGhost#12083
Fixes a parsing issue where negative offset values were incorrectly having the + sign added regardless of actual offset for sqlite databases.

For mysql databases absolute values of offset were taken with sign applied where appropriate to stop issues where both hours and minutes could be negative which would cause both an issue with offsets that could present as -2:30 and by the look of the code also trigger extra padding to result in -2:-030 rather than the expected -2:30
@sonyamann
Copy link

I still see a flat line in my dashboard. Fix not deployed yet?

@daniellockyer
Copy link
Member

@sonyamann This will be released later today in 3.39.0. If you're a Pro customer, it'll be rolled out on Thursday 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
affects:admin Anything relating to Ghost Admin affects:api Affects the Ghost API bug [triage] something behaving unexpectedly p2:major [triage] Bugs which we'll fix soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fixed member chart flat growth for GMT -X Timezones. iamscottcab/Ghost
7 participants
@kevinansfield @ErisDS @daniellockyer @rishabhgrg @matthanley @ceohockey60 @sonyamann