Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from mail setting is ignored for signup emails #15222

Closed
1 task done
marnixhoh opened this issue Aug 12, 2022 · 4 comments
Closed
1 task done

from mail setting is ignored for signup emails #15222

marnixhoh opened this issue Aug 12, 2022 · 4 comments

Comments

@marnixhoh
Copy link

Issue Summary

My email setting in config.production.json looks like this:

"mail": {
    "from": "'XXX' <XXX@XXX.com>",
    "transport": "SMTP",
    "options": {
      "host": "email-smtp.eu-central-1.amazonaws.com",
      "port": 465,
      "service": "SES",
      "auth": {
        "user": "XXX",
        "pass": "XXX"
      }
    }
  },

This config works for the emails sent to invited staff members. For these emails the correct from email address as specified in the above config is used.

But when someone subscribes, the email with the signup link they receive is sent from noreply@<blog-domain>. I.e. the from as specified in the config, is not used here.

Given that this is a transactional email and not a newsletter (bulk/mass) email, I would expect that that the mail config is used.

Please let me know if there is any more info I can provide. :)

Thank you so much for your time and effort looking into this!

Steps to Reproduce

  1. Use custom mail config as described above
  2. Test that this config is indeed used and working when inviting a new staff member
  3. Test that the from field form the config is ignored when someone subscribes

Ghost Version

5.8.0

Node.js Version

v16.16.0

How did you install Ghost?

Self hosted - AWS

Database type

MySQL 8

Browser & OS version

No response

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Aug 12, 2022
@ErisDS
Copy link
Member

ErisDS commented Aug 12, 2022

Duplicate of #15191

@ErisDS ErisDS marked this as a duplicate of #15191 Aug 12, 2022
@ErisDS ErisDS closed this as not planned Won't fix, can't repro, duplicate, stale Aug 12, 2022
@github-actions github-actions bot removed the needs:triage [triage] this needs to be triaged by the Ghost team label Aug 12, 2022
@marnixhoh
Copy link
Author

Hi @ErisDS. Thank you for commenting. Yes it is a duplicate of #15191, but that one got closed. And I do still believe that this is unexpected behavior.

The signup email does use the mail config in config.production.json. I.e. my config, as pasted above, uses AWS SES, except the from field in the config is not used.

So the reason this is unexpected behavior, is because when inviting a staff member, the entire mail config is used. But when someones signs up, the same config is used, except the from field gets ignored here. This seems to me like an odd discrepancy, which is not documented anywhere.

Please let me know if I can provide any more information. And thank you for looking into this! :)

@marnixhoh
Copy link
Author

marnixhoh commented Aug 15, 2022

I also just noticed that when a subscriber is logged in, the Contact support button opens an email to noreply@<domain>. This seems related to this issue.

I think that the blog owner, should be able to set the support email address? Letting users sent an email to a noreply@ email address seems odd.

@ErisDS
Copy link
Member

ErisDS commented Aug 15, 2022

I closed the other issue as a support request and routed the opener to the forum. The same is true for you. You're asking for help on how to use a feature, and that request for help does not belong on GitHub.

@TryGhost TryGhost locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants