Ghost shows unconfigured paid tier with filter="visibility:public+type=paid"

[fueko]

Issue Summary

Ghost shows an unconfigured paid tier $5/$50 with filter="visibility:public+type:paid" and an unconnected Stripe also this tier cannot be removed in the Portal options.

Steps to Reproduce

Test the setting for {{#get}} helper with filter="visibility:public+type:paid" without configuring Stripe and it will return a paid tier of $5/$50.

Ghost Version

5.22.4

Node.js Version

v16.13.0

How did you install Ghost?

Tested on localhost and server

Database type

SQLite3

Browser & OS version

No response

Relevant log / error output

No response

Code of Conduct

• I agree to be friendly and polite to people in this repository

[ErisDS]

Hey @fueko, so sorry for taking such a long time to get back to you on this one!

We agree the API behaviour is a little odd in this case, but from the perspective of creating themes, the best approach is to wrap the get helper in {{#if @site.paid_members_enabled}}{{/if}} (docs here). Using the feature flags for members you have full control over the behaviour of your themes based on the different settings.

In that regard - if there are any more feature flags that would be useful to help make themes more robust against the ever-expanding membership & newsletter settings, let us know!

I'll leave this open, as it would still probably make sense to change the tiers API to return nothing if paid memberships are not enabled.

[fueko]

Thanks very much for the clarifications, @ErisDS. I completely forgot about this helper, thanks!

[snoseeds]

Hi @ErisDS, kindly assign this issue to me

[snoseeds]

Hi @ErisDS, gentle reminder on this

[ErisDS]

@snoseeds A PR would be very welcome. We only assign issues to regular contributors.

[farhan787]

@ErisDS, I've opened a PR to fix this, need first time contributor approval to run the PR workflows.

[github-actions]

Our bot has automatically marked this issue as stale because there has not been any activity here in some time.

The issue will be closed soon if there are no further updates, however we ask that you do not post comments to keep the issue open if you are not actively working on a PR.

We keep the issue list minimal so we can keep focus on the most pressing issues. Closed issues can always be reopened if a new contributor is found. Thank you for understanding 🙂