Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Invalid Theme" when trying to add limit specification to {{recommendations}} helper #18836

Closed
1 task done
stromfeldt opened this issue Nov 2, 2023 · 1 comment
Closed
1 task done
Labels
bug [triage] something behaving unexpectedly

Comments

@stromfeldt
Copy link
Contributor

stromfeldt commented Nov 2, 2023

Issue Summary

I've integrated the {{recommendations}} helper into my theme locally, and have successfully uploaded that theme to Ghost(Pro). However, with mention of the new {{recommendations}} functionalities via the docs, and having amended {{recommendations}} to {{recommendations limit="10"}} (to use an example value given in the docs), the site works with the expected behaviour locally (without doing a restart) but the theme won't upload to Ghost(Pro).

Xnapper-2023-11-02-12 17 13

GScan gives a similar message.

As expected, doing a restart on the local instance does in fact result in an error message being displayed (even though the actual local site continues to work fine).

Xnapper-2023-11-02-12 55 07

Steps to Reproduce

  1. Add the limit specification to the {{recommendations}} helper (such as {{recommendations limit="10"}}).
  2. Upload the zipped theme
  3. See "Invalid Theme" message

Ghost Version

5.71.0+moya

Node.js Version

Yes

How did you install Ghost?

Ghost(Pro)

Database type

MySQL 5.7

Browser & OS version

Firefox 119, macOS 13.6

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Nov 2, 2023
@daniellockyer daniellockyer added the bug [triage] something behaving unexpectedly label Nov 2, 2023
@github-actions github-actions bot removed the needs:triage [triage] this needs to be triaged by the Ghost team label Nov 2, 2023
@daniellockyer
Copy link
Member

Thanks for the report, this was fixed in https://github.com/TryGhost/Ghost/releases/tag/v5.71.2 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [triage] something behaving unexpectedly
Projects
None yet
Development

No branches or pull requests

3 participants
@daniellockyer @stromfeldt and others