Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: ESC key is not dismissing tag suggestions #1893

Closed
ErisDS opened this issue Jan 9, 2014 · 2 comments
Closed

Bug: ESC key is not dismissing tag suggestions #1893

ErisDS opened this issue Jan 9, 2014 · 2 comments
Labels
bug [triage] something behaving unexpectedly
Milestone

Comments

@ErisDS
Copy link
Member

ErisDS commented Jan 9, 2014

Issue Summary

On the editor, when typing tags, a list of suggestions pops up if there are any tags with a similar name to the one you are typing. This list should be dismissed with the esc key. The code to do this exists, but it doesn't seem to be working.

Steps to Reproduce

  1. Ensure you already have some tags, by creating a post with a tag for example 'testing'
  2. Open the editor, and start typing the name of a tag which already exists, e.g. 'test
  3. Notice the suggestions list that pops up above the tag UI
  4. Press the 'ESC' key
  5. Note that the suggestions list has not disappeared

It is expected that the esc key close the suggestions list, however that is not currently the case.

Technical details:

  • Ghost Version: master (latest commit: fecb392)
  • Client OS: Mac OS X 10.8.5
  • Server OS: Localhost
  • Node Version: 0.10.18
  • Browser: Chrome 31.0.1650.63
@ErisDS
Copy link
Member Author

ErisDS commented Jan 13, 2014

This issue has gone into a special 0.4.1 milestone for a maintenance release sometime within the next month. Master will continue to be work in progress for the active milestone 0.5. A special 0.4-maintenance branch has been created. The workflow for these fixes is that PRs for 0.4.1 should be made to that branch rather than master and then I will merge it back into master.

Unfortunately, it's not possible to change open PRs to go to a different branch, a brand new PR has to be created & the old one closed.There were already many PRs open for the 0.4.1 issues before the branch was created, and I am not asking or requiring anyone with an already open PR to master to do this - I am able to manually merge the changes into the right branch. However, I will appreciate anyone who has a few minutes to save me the job 👍

@Damiya
Copy link
Contributor

Damiya commented Jan 13, 2014

Sorry for the double PR (reopened it against the correct branch!)

Going to look into putting together some functional tests to validate the tag editor behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [triage] something behaving unexpectedly
Projects
None yet
Development

No branches or pull requests

2 participants