Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps: Filter RSS feeds #2365

Closed
ErisDS opened this issue Mar 8, 2014 · 8 comments
Closed

Apps: Filter RSS feeds #2365

ErisDS opened this issue Mar 8, 2014 · 8 comments

Comments

@ErisDS
Copy link
Member

ErisDS commented Mar 8, 2014

In the discussion issue for the Filters API it was mentioned that it should be possible to filter RSS feeds.

The suggestion is that there should be a filter called rss.feed which filters the whole feed, and one called rss.item for each item. I’m not 100% certain that we need both, I believe that rss.feed would have access to all the data so could be used to do both, but I’m willing to be shown I’m wrong on this.

Anyhow, it would be great to get the rss filter into place so that it can be used in anger to create real world apps.

@ErisDS ErisDS added this to the 0.5 milestone Mar 8, 2014
@ErisDS ErisDS added the apps label Mar 8, 2014
@javorszky
Copy link
Contributor

"used in anger" +1 :D

Would the feed be the processed / rendered XML, or the big object that /core/server/controllers/frontend.js uses shortly before sending it out?

Personally having both would be fab. rss.item would be used to simply add data to each and every item of the feed (such as flotsam iTunes needs for a podcast), while rss.item could be used to add jetsam to the channel info.

@halfdan
Copy link
Contributor

halfdan commented Mar 8, 2014

Dibs^100

@halfdan
Copy link
Contributor

halfdan commented Mar 8, 2014

There are a few things we need to address here:

rss.item will always get passed a single post - so that one can fetch additional meta data (app_fields) for the post. rss.feed will allow you to change the head of the feed.

One thing to note: We currently use node-rss which is a very very limited package that doesn't allow you to add custom fields (like iTunes media fields) - dylang/node-rss#5

I have searched quite a bit for alternatives but to no avail. The best way to go at this is to build a new package that will allow a lot more flexibility. (I'm about to do that).

@MoriTanosuke
Copy link

👍 This would also allow to append a link to the original page inside the feed items. Useful if your site gets scraped by other parties and you want to make clear that the content is coming from your own site.

@halfdan
Copy link
Contributor

halfdan commented Mar 27, 2014

FYI: I started an App that can serve as example for the filters: https://github.com/halfdan/Ghostcast

@ErisDS
Copy link
Member Author

ErisDS commented Apr 3, 2014

👍 Are you working on adding in these filters?

@halfdan
Copy link
Contributor

halfdan commented Apr 3, 2014

Yea will do that.

halfdan added a commit to halfdan/Ghost that referenced this issue Apr 5, 2014
closes TryGhost#2365
- Filter feed options with rss.feed
- Filter feed item with rss.item
@ErisDS ErisDS modified the milestone: 0.6 Apps Sep 2, 2014
@halfdan halfdan mentioned this issue Sep 9, 2014
4 tasks
@ErisDS ErisDS added the later [triage] Things we intend to work but are not immediate priority label Jun 26, 2015
@ErisDS
Copy link
Member Author

ErisDS commented Jun 26, 2015

Temporarily closing all of the app specific issues (tagged with later). Will review & reopen those that are still relevant when we kick off that project, which should be shortly after Zelda lands.

@ErisDS ErisDS closed this as completed Jun 26, 2015
@ErisDS ErisDS removed later [triage] Things we intend to work but are not immediate priority labels Jan 23, 2019
tigefa4u pushed a commit to tigefa4u/Ghost that referenced this issue Aug 3, 2022
refs https://github.com/TryGhost/Team/issues/1571

- When creating a new newsletter, the counts were not loaded
- When updating a newsletter, the counts were not updated
- Requires TryGhost#14696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants