Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailer module refactor #2836

Closed
javorszky opened this issue May 30, 2014 · 0 comments · Fixed by #2912
Closed

mailer module refactor #2836

javorszky opened this issue May 30, 2014 · 0 comments · Fixed by #2912
Assignees
Labels
affects:api Affects the Ghost API

Comments

@javorszky
Copy link
Contributor

As #2742 painfully reminded us, the mailer module needs a boatload of refactor. The current implementation has circular dependency between mailer and the api.

The module should only concern itself with sending mail as per given data, and returning a status depending on whether sending it was successful or not. API calls and settings readings should be done earlier.

@ErisDS, can you assign this to me, please? I have a few ideas of where to move stuff*.

*subject to all other ideas, obviously

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:api Affects the Ghost API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants