-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: Harvesting client-side strings #6075
Comments
Thanks @kevinkucharczyk! I'm definitely up for starting work on this sooner rather than later as we're only going to gather more strings to translate as time goes by. As you say the first step is to get Once Finally, in order to add full internationalisation on the client we also need to consider #6050 and how we want to handle translation of API-provided messages. In conclusion, there's a lot to be done but nothing which can't be done incrementally, especially if it's taken into consideration when other changes are made. |
#6050 is an interesting one. I kinda like the idea of providing an i18n key to the client, which would look up its own translations. However, we are also translating the API messages themselves (in #5617), so I'm worried that this might lead to duplicate strings - they'd exist in both the client and server translation jsons and we would always need to be sure to update both files whenever we change one of the strings. |
Yeah, it's an interesting one - my initial thoughts on #6050 were that the API should be language-agnostic otherwise for every API request we also have to pass which language we expect back. However, if that is the case we would then expect any other clients of the API to use the default english response, provide their own translations, or offer some way for clients to retrieve language packs from the API that they could use for local translations. |
We could add an |
I started this job. |
i'd be glad to help on that, just point me in the right direction @kevinkucharczyk |
鈥擱eply to this email directly or view it on GitHub. |
The list of files requiring translation is out of date and the proposed addon for handling i18n also needs review - it looks like I'm going to close for now and mark as |
This is part of the i18n project described in #5345. I'd love to see some progress on this 馃槃
Harvesting server side strings is already in progress (see issue #5617), but we also need to start isolating strings inside the Ember app. This should be done using the ember-intl addon.
This is a big job, as we have lots of templates and .js files that have English strings which need to be moved to a translations file and hooked up with ember-intl.
So, the first thing to do is to setup the Ghost Ember app to work with ember-intl. I believe we should use the 2.0 branch of the project (as @morficus showed in his proof of concept). Once this is done, we can start working on translating individual files.
I've checked which files contain strings needing translating and this is what I found:
titleToken
that should be translated + some have alerts/other strings)As you can see, there's a lot to do here. If you're willing to work on this, feel free to leave a comment stating the files you're translating.
If there's anything I missed - please let me know!
To the Ghost Core team - if this is not the right time for translating client-side strings, then we could close this issue for now and open it up again later.
The text was updated successfully, but these errors were encountered: