New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jquery-ui and selectize dependencies #6458
Labels
affects:admin
Anything relating to Ghost Admin
Comments
kevinansfield
added a commit
to kevinansfield/Ghost
that referenced
this issue
Feb 9, 2016
refs TryGhost#6458, closes TryGhost#6457 - replaces jquery-ui.sortable with ember-sortable for drag-n-drop handling - moves the "new/blank" nav item out of the nav items list - allows it to be excluded from the draggable list - cleans up handling of the `navigationItems` array as there's no longer a need to ignore/exclude this extra item - clears validation errors when typing in the respective field - adds acceptance test for adding/removing nav items - improves acceptance test for saving nav items to cover more edge cases
4 tasks
4 tasks
acburdine
added a commit
to acburdine/Ghost
that referenced
this issue
Apr 19, 2016
5 tasks
geekhuyang
pushed a commit
to geekhuyang/Ghost
that referenced
this issue
Nov 20, 2016
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are currently bundling 2 large dependencies in the form of
jquery-ui
andselectize
+ember-cli-selectize
. jQuery UI is only used for drag-n-drop of the navigation items and re-ordering of tags. Selectize works well for our current use but is bloated due to needing to replicate a lot of functionality internally that Ember is much better at solving as well as needing a lot of sometimes flakey and inflexible glue code for communication and data munging between the jquery plugin and ember.Our current and future use cases would be better served by switching to the much more lightweight and flexible
ember-power-select
+ember-sortable
combo.ember-power-select offers very composable and flexible suite of components that work directly with Ember data structures so it will make our future plans for extending the search bar a lot easier.
TODO:
jquery-ui.sortable
toember-sortable
- Replace jquery-ui.sortable with ember-sortable for nav items #6468gh-search-input
fromgh-selectize
toember-power-select
- Convert gh-search-input to ember-power-select component #6492gh-selectize
toember-power-select
- Swap selectize tags input for ember-power-select+ember-drag-drop Admin#892Add "x"...
option is selectedjquery-ui
(+ additional plugins) andselectize
dependencies - Swap selectize tags input for ember-power-select+ember-drag-drop Admin#892Update 10/10/2017: Finalisation of this has been blocked for a long time on
ember-sortable
not supporting x+y re-ordering. There is now an on-going spike at usingember-drag-drop
instead in TryGhost/Admin#892.Any solution that we end up on should allow for customisation of individual tags/tokens so that primary tags can be disambiguated:
The text was updated successfully, but these errors were encountered: