Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Options for Content Helper #7931

Closed
CCHiggins opened this issue Feb 1, 2017 · 1 comment
Closed

Missing Options for Content Helper #7931

CCHiggins opened this issue Feb 1, 2017 · 1 comment
Assignees

Comments

@CCHiggins
Copy link

Issue Summary

I noticed when you use words or characters options to limit the output of the content helper, it's mainly a wrapper around the downsize package. The downsize package offers 2 additional options that would be useful to theme developers

  • Round would round content cutoff to the end of the next paragraph.
  • Append would add content after the cutoff.

I think adding round should be an easy fix (allow round to be selected in truncateOptions). Append could be handled in the same way but would limit append option to be used in conjunction with either words or characters.

@ErisDS
Copy link
Member

ErisDS commented Feb 7, 2017

Hi @CCHiggins, thanks for popping by!

There are (of course) reasons why support for those attributes weren't added. In fact they were largely added with Ghost in mind but have issues that caused us to rethink adding support.

There is a whole heap of discussion around the content & excerpt helpers in three currently open issues: #5060, #3846 and #2163.

I'm going to close this, as we don't need another issue, however by all means please contribute to those issues or pop by our slack channel to discuss moving them forward!

@ErisDS ErisDS closed this as completed Feb 7, 2017
@ErisDS ErisDS added the themes label Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants