Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese text issue on the new WYSIWYG editor #8319

Closed
amachino opened this issue Apr 12, 2017 · 8 comments
Closed

Japanese text issue on the new WYSIWYG editor #8319

amachino opened this issue Apr 12, 2017 · 8 comments
Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor

Comments

@amachino
Copy link

Issue Summary

On Ghost Alpha's new text editor, Japanese text can't be typed correctly with Japanese IME (input method).

untitled

Steps to Reproduce

  1. Select Japanese IME (either Apple's JapaneseIM or Google's Japanese IME)
  2. Type "watasi"
  3. Press Enter key

Expected Result

At step 2: "watasi" should be converted to "わたし"
At step 3: "わたし" should be converted to "私"

Actual Result

At step 2: "watasi" is converted to "wあたし"
At step 3: "wあたし" is converted to "w"

Technical details:

  • Ghost Version: 1.0.0-alpha.19
  • Node Version: v6.10.2
  • Browser/OS: Google Chrome / macOS Sierra
  • Database: MySQL 5.7.17
@kevinansfield kevinansfield added the affects:editor Work relating to the Koenig Editor label Apr 12, 2017
@disordinary
Copy link
Contributor

disordinary commented Apr 12, 2017

Thanks @Mach,

I just installed the Japanese keyboard on macOS and tried a few different options but couldn't replicate the issue. As a non Japanese speaker I have no idea what I'm doing though. Perhaps we could chat in the Ghost Slack team (https://slack.ghost.org/) or organise a hangout?

@amachino
Copy link
Author

amachino commented Apr 12, 2017

Hi @disordinary, thank you for following up.
I understand this issue is not easy to tackle by a non Japanese speaker..

Let me briefly explain about Japanese Input Method (IME):

  1. Japanese has three different alphabets (1. Hiragana, 2. Katakana, 3. Kanji)
  2. IME first converts English string (e.g. “watasi”) to Hiragana string (e.g. “わたし”) automatically
  3. At this point, the string “わたし” is not confirmed yet or still in editing mode (as you can see the underline below the string)
  4. When you press Space key, you can convert the Hiragana string “わたし” to other alphabets like “私”
  5. Finally, when you press Enter key, the string is confirmed

You can test above things in any textfield; TextEdit, Medium, etc.

The issue of Ghost Editor is:

  • When you start typing Japanese string (which start with a consonant like “w”) in the body area, “w” is somehow confirmed BEFORE you press Space or Enter key
  • That means, a word like “watasi” is divided into “w” & “atasi”, which is meaningless
  • Besides, when you press Enter key to start a new line, the string “atashi” disappeared

Please let me know if you need any help. I'm excited to see Ghost 1.0 😄

@ErisDS
Copy link
Member

ErisDS commented Apr 12, 2017

Hey @Mach,

Thanks for the detailed bug report! I wasn't able to locate/add the Japanese IME keyboard on my mac at first, but I do have Chinese Simplified Pinyin, which I believe is a similar concept (although one conversion not two) and I was able to reproduce the error with my limited memory of how to ask how someone is in Mandarin 😁

It seems to be a problem, specifically with the first character in the text card, after that, for example if I put english "Test" and then start typing it appears to work.

Now that I reproduced it that way, I experimented with the Japanese keyboard, installed that & selected Hiragana and got a similar although slightly different behaviour.

@disordinary If you choose Chinese - Pinyin Simplified and start typing the characters ni you should see this:

Put any other character first and then type ni and you get a menu of options:

In the case of typing ni hao ma in English, I would want this to convert to 你好吗.

This is slightly easier to demonstrate in Chinese because this gives a pop over menu, whereas the hiragana example auto-converts as you type.

@disordinary
Copy link
Contributor

disordinary commented Apr 12, 2017

Great, thanks @ErisDS!

This is an upstream issue in mobiledoc-kit, so I'll raise the issue there as well.

@disordinary
Copy link
Contributor

Can we confirm that this only occurs in an empty paragraph?

@kevinansfield kevinansfield added later [triage] Things we intend to work but are not immediate priority affects:admin Anything relating to Ghost Admin labels May 13, 2017
@ITJesse
Copy link

ITJesse commented Jul 23, 2017

I cannot use any other input method except English when I edit article on my iPad.
All input methods behave the same as English.But the hand write works well.
I don't know if it is a bug of Safari but I can only see it happen on the editor of Ghost.

Version of Ghost is 1.0.0
Version of iOS is 10.3.3

@ITJesse
Copy link

ITJesse commented Jul 23, 2017

img_0493

@ErisDS ErisDS removed later [triage] Things we intend to work but are not immediate priority labels Jan 23, 2019
@timeswind
Copy link

Having trouble with Chinese input methods too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor
Projects
None yet
Development

No branches or pull requests

6 participants