Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure sqlite3 uses a single database connection #5449

Merged
merged 1 commit into from Jun 18, 2015
Merged

Ensure sqlite3 uses a single database connection #5449

merged 1 commit into from Jun 18, 2015

Conversation

jaswilli
Copy link
Contributor

Closes #5411

  • Using rewire on the config package circumvents the singleton nature of required packages, resulting in a second instance of knex and a second connection to the sqlite3 database. If the connection being used in the test utils for writing to the database still has a lock, the connection doing the reading in the test suite will get a SQLITE_BUSY.

@jaswilli
Ensure sqlite3 uses a single database connection
c16db08 
Closes #5411
- Using rewire on the config package circumvents the
  singleton nature of required packages, resulting in a
  second instance of knex and a second connection to the
  sqlite3 database.
@sebgie
Copy link
Contributor

sebgie commented Jun 18, 2015

🔬 🏁

sebgie added a commit that referenced this pull request Jun 18, 2015
@sebgie
Merge pull request #5449 from jaswilli/issue-5411
7adad8d 
Ensure sqlite3 uses a single database connection
@sebgie sebgie merged commit 7adad8d into TryGhost:master Jun 18, 2015
@ErisDS
Copy link
Member

ErisDS commented Jun 18, 2015

🎉 🎈 🍰

@jaswilli jaswilli deleted the issue-5411 branch June 18, 2015 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaswilli @sebgie @ErisDS