Auth strategy refactor #5963
Merged
Auth strategy refactor #5963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErisDS
force-pushed
the
auth-strategy-refactor
branch
from
519dd1f
to
9db9112
Compare
- unit tests are not intended to call out to the db - this fakes the response from the model layer
- Simplifies both strategy & test code - Should have no side effects
ErisDS
force-pushed
the
auth-strategy-refactor
branch
from
9db9112
to
2c51a89
Compare
|
FYI I found this because I was trying to understand what parts of the crazy code in the model layer are unit tested, and some code that I didn't think got covered appeared as though it was. My next PR should hopefully add some more coverage in key areas that I need to refactor to solve #5604 & particularly #5615 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two commits here can be merged, I've kept them separate to start with to show that I'm not changing behaviour.
The first commit changes the tests from using the DB setup/teardown stuff to not using the DB, as unit tests are not intended to use the DB.
Whilst refactoring the tests, I realised that the slightly more complex
.forge().fetch()code can be 1-for-1 replaced withfindOne, which just removes a couple of lines of code in both the middleware and the tests, making it all a bit easier to follow, I think.This PR reduces test coverage, because it prevents the unit tests from executing some of the model layer code that wasn't actually being tested.