Fix changing text and jumping caret in PSM's date input #6184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#5777 - adds new `gh-datetime-input` that takes a one-way-bound value and formats it, only triggering the supplied `update` action on focus-out - fixes bug in PSM's `setPublishedAt` action if model's `published_at` is a Date object not a Moment object
kevinansfield
force-pushed
the
fix-date-input
branch
from
1245b5b
to
b858232
Compare
kevinansfield
changed the title
|
Changing to WIP, just noticed there's some odd behaviour around date validation for new posts. |
kevinansfield
changed the title
|
Figured out that the bug I'm seeing is not a new one, it's due to moment's date parsing coming up with a different date than intended. The fix in this PR should be good to go as it resolves a much more frustrating issue. |
9 tasks
ErisDS
added a commit
that referenced
this pull request
Dec 10, 2015
Fix changing text and jumping caret in PSM's date input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #5777
gh-datetime-inputthat takes a one-way-bound value and formats it, only triggering the suppliedupdateaction on focus-outsetPublishedAtaction if model'spublished_atis a Date object not a Moment objectI spent quite a while trying to adapt https://gist.github.com/rwjblue/2d7246875098d0dbb4a4 to work with a value that's formatted on the way in rather than on the way out but kept getting some odd behaviour. Went with this "cheat" workaround which should suffice for now until we get proper one-way-binding with angle components 馃槃