Improvements to client auth error logging #6214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main point of this PR is to output a useful error in the server console whenever an error occurs during the client auth flow.
There are quite a few different things that can be wrong. I've now got it so that there's a different error for:
In the first two cases, the error sent to the client is just 'Access denied'. The nice error only appears on the server.
In the latter case we already have a much nicer error for the client.
Please note: I also added one other change to this whilst I was there - I made the
localhost
override only work for non-production blogs. I think that makes sense?no issue