Remove setScrollClassName mixin and usage
#6216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we also remove the util itself? Does ember cli prune unused stuff from the ghost.js file? |
|
Oh, I'm sure I had deleted that util file! Will update 😄 |
kevinansfield
force-pushed
the
remove-set-scroll-classname
branch
from
ef543fc
to
6962630
Compare
no issue - removes `setScrollClassName` mixin that was previously used to add a `.scrolling` class to scrollable elements that showed a shadow at the top of boxes when not scrolled to the top
kevinansfield
force-pushed
the
remove-set-scroll-classname
branch
from
6962630
to
117ab27
Compare
ErisDS
added a commit
that referenced
this pull request
Dec 15, 2015
Remove `setScrollClassName` mixin and usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
setScrollClassNamemixin that was previously used to add a.scrollingclass to scrollable elements that showed a shadow at the top of boxes when not scrolled to the top