Including timezones API in configuration endpoint #6525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aileen
force-pushed
the
timezones_api
branch
from
45765c8
to
167572c
Compare
ErisDS
added a commit
to ErisDS/Ghost
that referenced
this pull request
Feb 19, 2016
refs TryGhost#6421, TryGhost#6525 - The configuration API endpoint was a bit of an animal: - It's used currently in two ways, once for general config, another for the about page. - These two things are different, and would require different permissions in future. - There was also both a browse and a read version, even though only browse was used. - The response from the browse was being artificially turned into many objects, when its really just one with multiple keys - The new version treats each type of config as a different single object with several keys - The new version therefore only has a 'read' request - A basic read request with no key will return basic config that any client would need - A read request with the about key returns the about config - A read request with a different key could therefore return some other config
aileen
force-pushed
the
timezones_api
branch
from
167572c
to
b78cd07
Compare
|
I changed the route for configuration/timezone regarding the changes from PR #6548. |
aileen
force-pushed
the
timezones_api
branch
from
b78cd07
to
381a5b0
Compare
aileen
changed the title
refs TryGhost#6406 - endpoint configuration/timezones refers to timezones.json file in data - added route for endpoint in api.js to use method read in configuration.js
aileen
force-pushed
the
timezones_api
branch
from
381a5b0
to
e347f95
Compare
sebgie
added a commit
that referenced
this pull request
Feb 24, 2016
Including timezones API in configuration endpoint
|
👍 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including timezones API in configuration endpoint
issue #6406