New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(twitter-card): use proper image tag #7025
Conversation
Hey @gergelyke! I can't say whether or not this can be merged, but you also need to re-write some of the tests. If you look at the travis failures it should show you which ones you need to edit. Thanks! 😄 |
Hello @acburdine , got it, fixing it now! G |
It is fixed - how can we make sure it is merged? Currently, the Twitter share card is not working with Ghost. |
Thanks! I'll take a look in a bit and verify it. What I meant by that earlier is that I wasn't sure if I myself should merge it. If it's not working with twitter currently though, I'll definitely check it. (I normally don't merge backend changes, I'm more of a frontend person) |
It works with facebook properly, but not with twitter. It should be merged asap. |
any chance we can merge it today? |
@gergelyke Even if we did, you'd still have to wait until the next release of ghost to use it in production 😄 /cc @ErisDS |
When would that happen? |
Hopefully soon, although the next release is a pretty big one so it might be another week or so. |
Got it ,thanks! |
@gergelyke Sorry for taking so long (had to figure out how to test it correctly). This looks good 👍 |
The reason:
https://dev.twitter.com/cards/types/summary
npm test
).