Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make amp work when blog is running in subdirectory #7353

Merged
merged 1 commit into from Sep 14, 2016

Conversation

acburdine
Copy link
Member

@acburdine acburdine commented Sep 10, 2016

closes #7352

  • use relative url instead of absolute url for post lookup
  • add test that passes w/these changes

TODO:

  • ensure 404s work correctly for amp posts not in a subdirectory
  • ensure 404s work correctly for amp posts in a subdirectory

closes TryGhost#7352
- use relative url instead of absolute url for post lookup
- add test that passes w/these changes
@acburdine acburdine changed the title Ensure amp works when blog is running in subdirectory [WIP] Ensure amp works when blog is running in subdirectory Sep 10, 2016
@acburdine acburdine changed the title [WIP] Ensure amp works when blog is running in subdirectory [WIP] Make amp work when blog is running in subdirectory Sep 10, 2016
@acburdine acburdine changed the title [WIP] Make amp work when blog is running in subdirectory Make amp work when blog is running in subdirectory Sep 10, 2016
@acburdine
Copy link
Member Author

@ErisDS this is good to go 👍

@ErisDS ErisDS merged commit 78f5807 into TryGhost:master Sep 14, 2016
mixonic pushed a commit to mixonic/Ghost that referenced this pull request Oct 28, 2016
closes TryGhost#7352
- use relative url instead of absolute url for post lookup
- add test that passes w/these changes
geekhuyang pushed a commit to geekhuyang/Ghost that referenced this pull request Nov 20, 2016
closes TryGhost#7352
- use relative url instead of absolute url for post lookup
- add test that passes w/these changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AMP doesn't work when blog is in a subdirectory
2 participants