🐛 Fixed kg-html-to-lexical creating unwanted text alignment and invalid nesting
#1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinansfield
force-pushed
the
kg-default-transforms
branch
2 times, most recently
from
13f9bdd
to
3d503cf
Compare
9larsons
added a commit
that referenced
this pull request
Oct 18, 2023
closes TryGhost/Product#4035 - added support for images wrapped in an anchor tag - previously only supported this if additionally wrapped in a figure - note: requires the package created in #1002 to provide valid lexical strings
…alid nesting refs TryGhost/Ghost#18448 - extracted our aligment stripping and denesting transforms to a new `kg-default-transforms` package - updated `kg-html-to-lexical` so it adds the transforms to the headless editor ensuring the output matches what we'd get if the same content was pasted directly into the editor
…e-specific denest in koenig-lexical
- with module build type we ran into issues when imported into commonjs package builds - with commonjs build type we need to explicitly import in koenig-lexical vite config
kevinansfield
force-pushed
the
kg-default-transforms
branch
from
3d503cf
to
97e4d5d
Compare
- extracted editor creation to test utils ready for re-use in individual transform tests - transforms are not run when using `setEditorState()` so we need to register them after that as they _are_ run when registering - we can't use `getEditorState()` immediately after registering transforms because they are still being run async, we can get around that by running an empty discrete update first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs TryGhost/Ghost#18448
kg-default-transformspackagekoenig-lexicalto use the new package in place of the extracted transform codekg-html-to-lexicalso it adds the transforms to the headless editor ensuring the output matches what we'd get if the same content was pasted directly into the editorTODO:
kg-html-to-lexicalto ensure input is modified as expectedkg-default-transforms