This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
Added cleanup on startup for old webhooks #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allouis
force-pushed
the
cleanup-old-webhooks
branch
2 times, most recently
from
790fa0a
to
2664b60
Compare
closes TryGhost/Ghost#12061 Due to a bug in Ghost webhooks are now created with a trailing "/" which meant that the previous webhooks to that (without a slash) was never removed. This results in users receiving emails from stripe about failed webhook delivery, which is not good at all. This fix lists out the webhooks and finds (if present) the webhook which matches the current URL, minus the trailing slash. If found it will then attempt to delete that webhook thus stopping the emails from Stripe. I've added a note to remove this code as it should only ever need to run once, and can be removed for the Ghost release after these changes.
allouis
force-pushed
the
cleanup-old-webhooks
branch
from
2664b60
to
190e22d
Compare
|
Hey @rishabhgrg can you give this a double check that it makes sense to you? |
rishabhgrg
approved these changes
Jul 20, 2020
allouis
added a commit
to allouis/Ghost
that referenced
this pull request
Jul 21, 2020
closes TryGhost#12061 Includes the code from TryGhost/Members#181
allouis
added a commit
to TryGhost/Ghost
that referenced
this pull request
Jul 21, 2020
closes #12061 Includes the code from TryGhost/Members#181
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-issue
Due to a bug in Ghost webhooks are now created with a trailing "/" which
meant that the previous webhooks to that (without a slash) was never
removed.
This results in users receiving emails from stripe about failed webhook
delivery, which is not good at all.
This fix lists out the webhooks and finds (if present) the webhook which
matches the current URL, minus the trailing slash. If found it will then
attempt to delete that webhook thus stopping the emails from Stripe.
I've added a note to remove this code as it should only ever need to run
once, and can be removed for the Ghost release after these changes.