This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
Used mode to determine flow for checkout session #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-issue This fixes a problem when subscribing to a Plan (Price) with a default trial period. We also add logging to add a little more information about which flow we're entering. Subscriptions that are started with a trial have a `setup_intent` present on the Checkout Session object, which was incorrectly causing us to determine that we are in a "setup" flow and attempt to update a customers card details. We now use the `mode` property of the Checkout Session to determine whether we are handling a new Subscription, or if we are in a "setup" flow and should update the Customer's card details.
allouis
added a commit
that referenced
this pull request
Jul 21, 2020
no-issue Reverting so that changesets can be released independently This reverts commit 0b737e7.
allouis
added a commit
that referenced
this pull request
Jul 21, 2020
no-issue This fixes a problem when subscribing to a Plan (Price) with a default trial period. We also add logging to add a little more information about which flow we're entering. Subscriptions that are started with a trial have a `setup_intent` present on the Checkout Session object, which was incorrectly causing us to determine that we are in a "setup" flow and attempt to update a customers card details. We now use the `mode` property of the Checkout Session to determine whether we are handling a new Subscription, or if we are in a "setup" flow and should update the Customer's card details.
allouis
added a commit
to allouis/Ghost
that referenced
this pull request
Jul 21, 2020
no-issue This fixes a problem when subscribing to a Plan (Price) with a default trial period. We also add logging to add a little more information about which flow we're entering. Subscriptions that are started with a trial have a present on the Checkout Session object, which was incorrectly causing us to determine that we are in a setup flow and attempt to update a customers card details. We now use the property of the Checkout Session to determine whether we are handling a new Subscription, or if we are in a setup flow and should update the Customer's card details. Includes the code from TryGhost/Members#184
allouis
added a commit
to TryGhost/Ghost
that referenced
this pull request
Jul 21, 2020
no-issue This fixes a problem when subscribing to a Plan (Price) with a default trial period. We also add logging to add a little more information about which flow we're entering. Subscriptions that are started with a trial have a present on the Checkout Session object, which was incorrectly causing us to determine that we are in a setup flow and attempt to update a customers card details. We now use the property of the Checkout Session to determine whether we are handling a new Subscription, or if we are in a setup flow and should update the Customer's card details. Includes the code from TryGhost/Members#184
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-issue
This fixes a problem when subscribing to a Plan (Price) with a default
trial period. We also add logging to add a little more information about
which flow we're entering.
Subscriptions that are started with a trial have a
setup_intentpresent on the Checkout Session object, which was incorrectly causing us
to determine that we are in a "setup" flow and attempt to update a
customers card details.
We now use the
modeproperty of the Checkout Session to determinewhether we are handling a new Subscription, or if we are in a "setup"
flow and should update the Customer's card details.