This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
Ensured that we do not insert orphaned rows #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-issue Previously we would blindly put subscriptions into the database when we received a webhook, which could result in orphaned rows that were not linked to a customer (and by extension a member) This updates the logic so that we will only add subscriptions if we have a record of their customer. Customers are only added during a checkout.session.completed webhook, at which point a member is guarunteed, but for formailty and safety against changes in the flow, the logic has been applied to inserting customers too.
allouis
added a commit
to allouis/Ghost
that referenced
this pull request
Jul 24, 2020
no-issue This contains an update which ensures that we do not insert orphaned rows into the database Includes code from: TryGhost/Members#190
allouis
added a commit
to TryGhost/Ghost
that referenced
this pull request
Jul 24, 2020
no-issue This contains an update which ensures that we do not insert orphaned rows into the database Includes code from: TryGhost/Members#190
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-issue
Previously we would blindly put subscriptions into the database when we
received a webhook, which could result in orphaned rows that were not
linked to a customer (and by extension a member)
This updates the logic so that we will only add subscriptions if we have
a record of their customer.
Customers are only added during a checkout.session.completed webhook, at
which point a member is guarunteed, but for formailty and safety against
changes in the flow, the logic has been applied to inserting customers
too.