This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
Fix auth pages flashing #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs #36 This will allow the members-browser-auth library to post messages to the auth-pages iframe, asking it to update the location from inside the frame.
refs #36 This removes the behaviour of forcing the `src` property to change when opening the auth pages and insteads posts a message "asking" the auth pages to update the location hash.
allouis
force-pushed
the
fix-auth-pages-flashing
branch
from
608527b
to
338dfde
Compare
allouis
added a commit
to allouis/Ghost
that referenced
this pull request
Jul 9, 2019
closes TryGhost#10888 The real work for this was done in: TryGhost/Members#37 Installed @tryghost/members-auth-pages@1.1.0 Installed @tryghost/members-theme-bindings@0.2.3
allouis
added a commit
to TryGhost/Ghost
that referenced
this pull request
Jul 9, 2019
closes #10888 The real work for this was done in: TryGhost/Members#37 Installed @tryghost/members-auth-pages@1.1.0 Installed @tryghost/members-theme-bindings@0.2.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the auth-pages to change the location hash from within the iframe, and the browser auth to post a message asking it to do so.