Added support for joining to virtual tables #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost/Product#944 Currently mongo-knex does not allow setting up relations which use an aggregate function, e.g. filtering based on the SUM of a related column. I initially looked at adding a new relation type like `oneToOneAggregate` but this proved to require large changes to the codebase, with a big increase in complexity. The approach here is to allow consumers of the library to have the ability to define a virtual table as a knex query, which allows for more complex relations, including aggregates, or joins over multiple tables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/TryGhost/Team/issues/944
Currently mongo-knex does not allow setting up relations which use an
aggregate function, e.g. filtering based on the SUM of a related column.
I initially looked at adding a new relation type like
oneToOneAggregatebut this proved to require large changes to thecodebase, with a big increase in complexity.
The approach here is to allow consumers of the library to have the
ability to define a virtual table as a knex query, which allows for more
complex relations, including aggregates, or joins over multiple tables.