Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handlebars version is vulnerable #163

Closed
g-marconet opened this issue Sep 25, 2019 · 3 comments
Closed

handlebars version is vulnerable #163

g-marconet opened this issue Sep 25, 2019 · 3 comments

Comments

@g-marconet
Copy link

express-hbs is currently using version 4.1.2 of Handlebars, which npm audit complains is vulnerable to a prototype pollution attack. Update to Handlebars >=4.3.0 to fix this issue.

Example npm audit from my project:

$ npm audit
                        === npm audit security report ===                        
                                                                                
┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ handlebars                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=4.3.0                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ express-hbs                                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ express-hbs > handlebars                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1164                            │
└───────────────┴──────────────────────────────────────────────────────────────┘
found 1 high severity vulnerability in 54307 scanned packages
  1 vulnerability requires manual review. See the full report for details.
@g-marconet g-marconet changed the title Update handlebars to a version that has no known vulnerabilities handlebars version is vulnerable Sep 25, 2019
@mat8913
Copy link

mat8913 commented Sep 28, 2019

According to https://www.npmjs.com/advisories/1164/versions, version 4.1.2-0 is unaffected. I assume the API is quite similar to 4.1.2, so would switching to version 4.1.2-0 be an easy fix?

@g-marconet
Copy link
Author

According to https://www.npmjs.com/advisories/1164/versions, version 4.1.2-0 is unaffected. I assume the API is quite similar to 4.1.2, so would switching to version 4.1.2-0 be an easy fix?

Good catch. I applied that change in #165 .

@ErisDS
Copy link
Member

ErisDS commented Oct 22, 2019

Fixed with express-hbs 2.2.0

@ErisDS ErisDS closed this as completed Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants