Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few PRs out for this already, but one breaks tests and another only covers upgrades to
lodash
.This updates
handlebars
,lodash
, and does its best to use non-vulnerable versions of downstream dev dependencies withnpm audit fix
. There are two outstanding vulnerabilities in a dependency ofistanbul
, but they required updating 3 major versions to fix and I do not know enough about this codebase to make that change.Why this PR?
express-hbs
version2.1.2
pins a vulnerable version ofhandlebars
. This causes all downstream projects to report vulnerabilities whennpm audit
is run.How do I know this fixes vulnerabilities?
Run
npm audit --production
and observe that it "found 0 vulnerabilities".