Update vulnerable dependencies #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
+1 for getting this merged and published to npm! |
|
Istanbul is just for coverage. Upgrade should be safe else rip it out for
now.
Aware that express hbs needs love but in an insane busy period that will
last one more week.
Will try to get to it earlier if possible
…On Thu, 3 Oct 2019 at 16:15, Ben Brown ***@***.***> wrote:
+1 for getting this merged and published to npm!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#165>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAYZCLABP7QHJ2ECWCLSZTQMYEARANCNFSM4I35J2WQ>
.
|
|
Thanks for your help! I've redone the dependency updates as more had been flagged vulnerable in the meantime. Express-hbs 2.2.0 has been published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few PRs out for this already, but one breaks tests and another only covers upgrades to
lodash.This updates
handlebars,lodash, and does its best to use non-vulnerable versions of downstream dev dependencies withnpm audit fix. There are two outstanding vulnerabilities in a dependency ofistanbul, but they required updating 3 major versions to fix and I do not know enough about this codebase to make that change.Why this PR?
express-hbsversion2.1.2pins a vulnerable version ofhandlebars. This causes all downstream projects to report vulnerabilities whennpm auditis run.How do I know this fixes vulnerabilities?
Run
npm audit --productionand observe that it "found 0 vulnerabilities".