Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handlebars v2.0 #63

Merged
merged 1 commit into from May 30, 2014
Merged

Handlebars v2.0 #63

merged 1 commit into from May 30, 2014

Conversation

phillipj
Copy link
Contributor

Hi,

thanks for creating this module, I've been using it alot! This updates to handlebars v2.0. As its still in alpha you should probably not merge it just yet, hopefully a stable release will happen soon.

I'm using this version myself as I have the need to retrieve data from the root context in my templates. Support for retrieving data from root was added in v2.0.0-alpha.1 with this syntax {{@root.foo}}. Read more about it in issue handlebars-lang/handlebars.js#392.

Tip for anyone else who wants to test handlebars v2.0 in their projects:

$ npm install git://github.com/phillipj/express-hbs#feature/handlebars-2.0

@mgutz mgutz merged commit 89775c0 into TryGhost:master May 30, 2014
@FredKSchott
Copy link

@phillipj hinted at this in the PR, but in the future you probably don't want to update your module to use alpha versions of its dependencies. Since handlebars 2.0 is still in alpha/unstable, this module should now be considered unstable as well until handlebars 2.0.0 is released.

@mgutz
Copy link

mgutz commented Aug 11, 2014

Agree @FredKSchott. I should be more careful. I assumed it had been released. This library allows the use of user installed handlebars via handlebars option

hbs.express3({
 ... 
 handlebars: "{Module} Use external handlebars instead of express-hbs dependency"
 );
` ``

@phillipj phillipj deleted the feature/handlebars-2.0 branch August 11, 2014 18:44
@FredKSchott
Copy link

no worries, its an easy thing to miss :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants