Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to Gatsby V4 stable #423

Closed
wants to merge 13 commits into from
Closed

Conversation

rmatambo8
Copy link
Collaborator

@rmatambo8 rmatambo8 commented Sep 3, 2021

Hi! In case you didn’t know, Gatsby is planning its next major version for Q4 of this year! In preparation, the Gatsby team is reaching out to maintainers for our most popular Starters to help make the upgrade to Gatsby 4 as smooth as possible.

This PR updates your Gatsby Starter to the alpha version of this next release, as well as some related plugins. It’s just in draft form for now, since the 4.0.0 version of Gatsby isn’t quite ready for release yet. We’re mainly testing updating Gatsby and the other official plugins to ensure that the Starter builds without errors.

You may see some warnings from packages that list gatsby: ^3.0.0 as a peer dependency. Don’t worry, we’ll come back and fix those before we take this PR out of draft mode when it’s ready to be merged.

  • Note: Gatsby 4 requires Node v14. This is a change from Gatsby 3, which worked with Node v12.13 or newer.

Once version 4.0.0 is ready, we'll come back to update the dependencies and convert this draft to a PR for review. Until then, no action is required on your end. If you have any questions / concerns, let us know in the comments.

Thanks again for all your work as a Gatsby maintainer. We’re so grateful to have you as part of our community. 💜

For more information on what’s coming with Gatsby v4, check out the [GitHub Discussion](https://github.com/gatsbyjs/gatsby/discussions/32860](https://github.com/gatsbyjs/gatsby/discussions/32860).

Changes:

  • upgraded package.json to include gatsby 4 alpha packages
  • updated the webpack config in gatsby-node.js to include webpack 5 polyfill changes
  • Changed react import syntax to use preferred syntax
  • Added recommended script commands to package.json
  • checked accessibility: no critical issues
  • updated gatsby-image to gatsby-plugin-image

@rmatambo8
Copy link
Collaborator Author

I recently upgraded everything to beta and it seems to work correctly on my machine, we're getting closer to the finish line 🐎 🎉

@rmatambo8
Copy link
Collaborator Author

I'm not sure why I'm getting the mixed content error from netlify and I didn't change any of the routing logic in the application, is this something you're familiar with?

@aileen
Copy link
Member

aileen commented Oct 6, 2021

Hey @rmatambo8 !

Thank you for the PR! Happy to get this through. Don't worry so much about the mixed content, that is because the siteUrl is currently set to a default value of http://localhost:8000 so this starter works locally.

If you wanna rebase, we can happily merge this PR.

@rmatambo8
Copy link
Collaborator Author

I just walked through all of the merge conflicts, and it looks like we are almost good to go.

here is a live version of your site built on gatsby cloud: live link

We are planning on having a major launch day this month and we would like to merge all of these changes, we would like to feature your starter from day 1 of Gatsby 4 GA. Would you be up for merging on the launch day?

As always, thanks again for being awesome as a Gatsby maintainer. We’re so grateful to have you as part of our community. 💜

Feel free to jump into the discussion on quality starters for Gatsby v4 in the GitHub Discussion

@rmatambo8 rmatambo8 marked this pull request as ready for review October 21, 2021 21:37
@rmatambo8
Copy link
Collaborator Author

rmatambo8 commented Oct 21, 2021

@aileen Gatsby 4 is GA today! Just updated the related dependencies to the ^4.0.0 versions. If everything looks good, feel free to merge!

👍

If any new conflicts come up, i've allowed edits by the maintainer so you can feel free to fix any merge conflicts that come up after this.

Once this is done, you can let me know so that we can feature this in our starters library

One thing to note is:
gatsby-plugin-feed now requires the title to be set directly in order to run. I added {title: "No title"} to the generated RSS feed that would get overwritten by your setup step.

@rmatambo8 rmatambo8 changed the title Updating to Gatsby V4 Alpha Updating to Gatsby V4 stable Oct 22, 2021
@rmatambo8
Copy link
Collaborator Author

rmatambo8 commented Oct 26, 2021

Hey @aileen, We just wanted to let you know that we will be removing any starters that are not on Gatsby v4 from our starters library within the next 24 hours.

We would like to keep featuring your starter so if you upgrade to gatsby v4, you can send us a message here and we will add it back to the starters library

@aileen
Copy link
Member

aileen commented Oct 27, 2021

Hey @rmatambo8 Could you fix the conflicts please? We can then merge it into main

@rmatambo8
Copy link
Collaborator Author

Hey @aileen, you can merge when ready.

I've fixed the merge conflicts. If any new merge conflicts come up I will not be able to assist as I'm moving on to other work.

@agent-reed
Copy link

Would love to see this merged!

@ecda909
Copy link

ecda909 commented Dec 3, 2021

I would also love to see this merged as well!

@aileen
Copy link
Member

aileen commented May 30, 2022

Closing in favour of #510

@aileen aileen closed this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants