Created "ghost:theme [name]" command and improved README.md file

[tonnyorg]

Per my main proposal on this PR for the Ghost-Cli and per all the feedback received, the first step for me was to get familiar with your generator for Yeoman, which I feel like we can keep maintaining it so users have 2 ways to create/generate stuff for Ghost: through Yeomain (this generator) and through Ghost-Cli (which is going to call this generator somehow, still working on this portion).

Anyway, back to the point, here is my proposal to create a very basic scaffolding for a Ghost theme from scratch, let me know what do you think about it :)

To test it yourself, use npm/yarn link command from the inside of this project folder, update the dependencies with npm install or yarn command, and later just run yo ghost:theme [your_new_themes_name].

The next step is to actually move everything to support ES6 and work with the latest practices/standards/version of Yeomain (per the tutorials I followed when I was doing a generator from scratch the code look a little bit different).

Later once I get this done and also implemented on Ghost-Cli, my goal is to create a command like yo ghost:theme-export [src_folder] [dest_filename] that basically performs npm run build (this will require a minor improvement on the skeleton theme) script in your theme to compile the assets and later compress the theme folder into a zip file so you can share your theme with anyone else.

What do you think?

[acburdine]

@tonnyorg thanks for the PR! gonna hold off for a bit before merging though - I need to clean up this repo first 😄 Will get to it as soon as I can though!

[tonnyorg]

Sounds good, I'll keep an eye here as well. TY!

[kevinansfield]

Hey @tonnyorg 👋 There's a new gallery feature coming in Ghost 2.1.0 that has some required JS and CSS in themes. You can see the changes in this Casper PR, I would suggest that the CSS used in Casper for the gallery layout should be used as-is in the generated template TryGhost/Casper#475

Let me know if you have any questions 😄

[tonnyorg]

@kevinansfield I totally agree but there's something to consider:

@JohnONolan suggested here to keep the CSS at minimal possible so I'm worried about adding this because it would mean that we will have to add more "base" style in the future, and that might be not "ideal".

What do you think? A workaround of this would be to create a separated [theme]/assets/css/koenig/gallery-card.css file that we can easily import into the main css file (screen.css) and put the style in there so further developers can understand that this is "optional" but all the classes to work with the gallery are there for further customization. This will allow maintainers to push new styles (for further cards or utilities) without affecting the basic CSS for new themes. How does that sounds?

[kevinansfield]

@tonnyorg in this case the CSS isn't optional, it's part of the base style for a theme. The idea here is to avoid theme developers having to go to the docs to copy/paste required CSS and JS by ensuring that the empty theme generator includes the minimal needed for Ghost to work and pass validation.

John's previous comment was correct at the time because there wasn't any Ghost functionality that required CSS.

[tonnyorg]

@kevinansfield gotcha, that makes sense now. I'm going to work on the improvement tonite. TY!

[tonnyorg]

@kevinansfield all set, feel free to review it and share your feedback with me 👍