switch to prebuild for better binary distribution and electron support #1641
Labels
Comments
|
Also node-pre-gyp is hitting a bit of a dead-end. See mapbox/node-pre-gyp#657 |
|
I'm also coming to the same conclusion 🙂 I'd like to serve I'd welcome a PR to change over to prebuild. Else I can look at changing this but I have no ETA on that right now |
|
That being said, it doesn't look like it would solve my problem: prebuild/prebuild#174 |
daniellockyer
added a commit
that referenced
this issue
Dec 24, 2023
…stall` fixes #1641 fixes #1721 fixes #1714 fixes #1713 fixes #1700 fixes #1704 - `@mapbox/node-pre-gyp` is effectively unmaintained [1] as has a few bugs which our users keep running into - it seems the prebuilt binary world has moved in favor of prebuild + it's various other forms - one option would be to use prebuildify to bundle all binaries into the package, but that's a step too far removed from the current situation for now - instead, we can use prebuild-install to download the binaries, and `prebuild` to build + upload the binaries - this means we can remove node-pre-gyp and fix a bunch of issues! [1]: mapbox/node-pre-gyp#657
daniellockyer
added a commit
that referenced
this issue
Dec 24, 2023
…stall` fixes #1641 fixes #1721 fixes #1714 fixes #1713 fixes #1700 fixes #1704 - `@mapbox/node-pre-gyp` is effectively unmaintained [1] as has a few bugs which our users keep running into - it seems the prebuilt binary world has moved in favor of prebuild + it's various other forms - one option would be to use prebuildify to bundle all binaries into the package, but that's a step too far removed from the current situation for now - instead, we can use prebuild-install to download the binaries, and `prebuild` to build + upload the binaries - this means we can remove node-pre-gyp and fix a bunch of issues! - eventually, we could start providing electron prebuilt binaries too [1]: mapbox/node-pre-gyp#657
It would appear prebuild is also effectively unmaintained! Time to switch to prebuildify? prebuild/prebuild#174 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Currently node-sqlite3 uses node-pre-gyp for building and delivers only node compatible modules.
Proposed implementation
To achieve wider binary distribution and to support electron prebuild binaries, a support for prebuild is desired.
See https://nodejs.github.io/node-addon-examples/build-tools/prebuild/
The text was updated successfully, but these errors were encountered: