Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: alternative update of node-gyp for electron (v5 & v6), windows #1245

Merged
merged 26 commits into from
Nov 21, 2019
Merged

deps: alternative update of node-gyp for electron (v5 & v6), windows #1245

merged 26 commits into from
Nov 21, 2019

Commits on Nov 11, 2019

  1. deps: alternative update of node-gyp for electron (v5 & v6), windows

    @kewde
    kewde committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    f5b58bc View commit details
    Browse the repository at this point in the history

  2. deps: install globally

    @kewde
    kewde committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    a621fa8 View commit details
    Browse the repository at this point in the history

  3. deps: force installation into the folder that node-pre-gyp uses 

    force an updated version into the directory that node-pre-gyp uses to fetch node-gyp from
"C:\Program Files\nodejs\node_modules\npm\node_modules"
    @kewde
    kewde committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    4adafad View commit details
    Browse the repository at this point in the history

  4. deps: quotes around file path due to space

    @kewde
    kewde committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    ebd0a28 View commit details
    Browse the repository at this point in the history

  5. deps: remove node_modules in path

    @kewde
    kewde committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    a67b0b1 View commit details
    Browse the repository at this point in the history

  6. deps: use %ProgramFiles% to dynamically locate the directory

    @kewde
    kewde committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    678b40d View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2019

  1. deps: detect environment to build for using %platform%

    @kewde
    kewde committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    cb93e18 View commit details
    Browse the repository at this point in the history

  2. deps: logging and small typo fix

    @kewde
    kewde committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    58bf68f View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. deps: set variable outside of if statement

    @kewde
    kewde committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    520d06a View commit details
    Browse the repository at this point in the history

  2. deps: add debug logging

    @kewde
    kewde committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    dc52a9b View commit details
    Browse the repository at this point in the history

  3. deps: specify electron runtime better

    @kewde
    kewde committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    dab13be View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. deps: fix set variable, no spaces

    @kewde
    kewde committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    5133fa4 View commit details
    Browse the repository at this point in the history

  2. deps: try double "

    @kewde
    kewde committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    06c21aa View commit details
    Browse the repository at this point in the history

  3. try without quotes (i hate batch)

    @kewde
    kewde committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    913a326 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2019

  1. deps: move goto outside of if

    @kewde
    kewde committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    919de28 View commit details
    Browse the repository at this point in the history

  2. add debug logging

    @kewde
    kewde committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    8f577f8 View commit details
    Browse the repository at this point in the history

  3. more debug logging

    @kewde
    kewde committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    9dc8271 View commit details
    Browse the repository at this point in the history

  4. add back quotes

    @kewde
    kewde committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    c6db64d View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2019

  1. remove /I from if

    @kewde
    kewde committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    092f015 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. unnest if and remove debug logging

    @kewde
    kewde committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    cc1b6b5 View commit details
    Browse the repository at this point in the history

  2. add debug

    @kewde
    kewde committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    46c095a View commit details
    Browse the repository at this point in the history

  3. attempt without IF "%NODE_RUNTIME%"=="electron"

    @kewde
    kewde committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    f36f5ec View commit details
    Browse the repository at this point in the history

  4. add additional IF %ERRORLEVEL% NEQ 0 GOTO ERROR

    @kewde
    kewde committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    7ebe69c View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2019

  1. more logging on NODE_RUNTIME_VERSION

    @kewde
    kewde committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    6a6dcb0 View commit details
    Browse the repository at this point in the history

  2. move logic to add in debugging

    @kewde
    kewde committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    3adec9f View commit details
    Browse the repository at this point in the history

  3. fix %

    @kewde
    kewde committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    b318e2c View commit details
    Browse the repository at this point in the history