Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require throw to add trace info for verbose mode #1317

Merged
merged 1 commit into from
Apr 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions lib/trace.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,14 @@ function extendTrace(object, property, pos) {
var cb = arguments[pos];
if (typeof arguments[pos] === 'function') {
arguments[pos] = function replacement() {
try {
return cb.apply(this, arguments);
} catch (err) {
if (err && err.stack && !err.__augmented) {
err.stack = filter(err).join('\n');
err.stack += '\n--> in ' + name;
err.stack += '\n' + filter(error).slice(1).join('\n');
err.__augmented = true;
}
throw err;
var err = arguments[0];
if (err && err.stack && !err.__augmented) {
err.stack = filter(err).join('\n');
err.stack += '\n--> in ' + name;
err.stack += '\n' + filter(error).slice(1).join('\n');
err.__augmented = true;
}
return cb.apply(this, arguments);
};
}
return old.apply(this, arguments);
Expand Down
60 changes: 60 additions & 0 deletions test/verbose.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
var sqlite3 = require('..');
var assert = require('assert');

var invalid_sql = 'update non_existent_table set id=1';

var originalMethods = {
Database: {},
Statement: {},
};

function backupOriginalMethods() {
for (var obj in originalMethods) {
for (var attr in sqlite3[obj].prototype) {
originalMethods[obj][attr] = sqlite3[obj].prototype[attr];
}
}
}

function resetVerbose() {
for (var obj in originalMethods) {
for (var attr in originalMethods[obj]) {
sqlite3[obj].prototype[attr] = originalMethods[obj][attr];
}
}
}

describe('verbose', function() {
it('Shoud add trace info to error when verbose is called', function(done) {
var db = new sqlite3.Database(':memory:');
backupOriginalMethods();
sqlite3.verbose();

db.run(invalid_sql, function(err) {
assert(err instanceof Error);

assert(
err.stack.indexOf(`Database#run('${invalid_sql}'`) > -1,
`Stack shoud contain trace info, stack = ${err.stack}`
);

done();
resetVerbose();
});
});

it('Shoud not add trace info to error when verbose is not called', function(done) {
var db = new sqlite3.Database(':memory:');

db.run(invalid_sql, function(err) {
assert(err instanceof Error);

assert(
err.stack.indexOf(invalid_sql) === -1,
`Stack shoud not contain trace info, stack = ${err.stack}`
);

done();
});
});
});