Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next version of Kickoff #60

Closed
14 tasks done
mrmartineau opened this issue Sep 4, 2015 · 5 comments
Closed
14 tasks done

Next version of Kickoff #60

mrmartineau opened this issue Sep 4, 2015 · 5 comments
Assignees
Milestone

Comments

@mrmartineau
Copy link
Member

Hey @ashleynolan & @nicbell, here's my list for the next version of Kickoff, please add any other things that you'd like. I don't think this is a v6, but probably a v5.1.0.. what do you think?

  • Switch to Browserify? see Use Browserify by default? #57
    • Switch to minifify in the Browserify build
    • Remove grunt-contrib-uglify
    • Remove chotto if we move to Browserify build is not needed anymore
  • Add a modifier to .l-blockGrid > .l-blockgrid--guttered. Thanks @nicbell
    • remove dependency on unordered lists @nicbell, will you be able to do this?
  • Update custom radios & checkboxes. 50% done by @mrmartineau
  • Remove some grunt plugins
    • Remove Grunt photobox, what do you think?
  • Update package.json to move some items in optionalDependencies. @nicbell
  • Refactor the .media element so it doesn't always stack on skinny viewports
  • Simplify tables @ashleynolan Look at defaults for tables #61
  • Add jsHint and scsslint tasks @ashleynolan
  • Use cutting the mustard test for loading shims
@mrmartineau mrmartineau added this to the v5.1.0 milestone Sep 4, 2015
@mrmartineau mrmartineau self-assigned this Sep 4, 2015
@ashleynolan
Copy link
Contributor

I think all of those sound like sensible things to move towards. I’ll have a think if there’s anything else that might be worth adding.

Happy to pickup the Browserify stuff – I’m on holiday for a few weeks from next Thursday, but can do it when I get back (unless someone else wants to do it before then).

@mrmartineau
Copy link
Member Author

We can handle the Browserify stuff. We (@nicbell & I) have a good setup on our current project so will port it over. We are using minifify instead of uglify btw.

@ashleynolan
Copy link
Contributor

Will add back in the SCSS and JS linting tasks tomorrow as should have time to do so then

@mrmartineau
Copy link
Member Author

@ashleynolan once you have made the linting changes, we should have a code freeze. Cool?

@ashleynolan
Copy link
Contributor

Sounds good - will merge it tomorrow morning.

Managed to get sidetracked by bringing down one of JE's sites today for a
bit... :/

On Tuesday, 17 November 2015, Zander Martineau notifications@github.com
wrote:

@ashleynolan https://github.com/ashleynolan once you have made the
linting changes, we should have a code freeze. Cool?


Reply to this email directly or view it on GitHub
#60 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants