Fix: Clean up desktop UI console errors/warnings #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leblowl
commented
Jan 15, 2024
| Leave community | ||
| </Typography> | ||
| </Grid> | ||
| )} |
There was a problem hiding this comment.
Apparently, when nesting certain things inside of material components that are not expecting it, weird errors can happen where it passes attributes to the DOM that it shouldn't. I figured this out by stumbling upon an issue that was describing something similar. I'm not sure where that issue went now, but can probably find it. Of course, it's easy to see how this causes errors by running the current version and the new changes.
siepra
approved these changes
Jan 16, 2024
leblowl
force-pushed
the
fix-js-warnings
branch
2 times, most recently
from
ab646a6
to
c56f115
Compare
On desktop, the browser was emitting several errors/warnings that
filled up the console. Some of these were related to React and then
some of them related to HTML preload. The preload warning says, "A
preload for {url} is found, but is not used because the request
credentials mode does not match. Consider taking a look at crossorigin
attribute." and then a little later it says, "The resource {url} was
preloaded using link preload but not used within a few seconds from
the window's load event. Please make sure it has an appropriate `as`
value and it is preloaded intentionally." Removing the crossorigin
attribute on the font links removed the preload warning and it looks
like everything is preloading correctly to me in dev/production (fonts
load at the very beginning and no warnings). Maybe if CORS is not used
then it also doesn't want crossorigin attribute.
leblowl
force-pushed
the
fix-js-warnings
branch
from
c56f115
to
50858b0
Compare
siepra
pushed a commit
that referenced
this pull request
Jan 17, 2024
On desktop, the browser was emitting several errors/warnings that
filled up the console. Some of these were related to React and then
some of them related to HTML preload. The preload warning says, "A
preload for {url} is found, but is not used because the request
credentials mode does not match. Consider taking a look at crossorigin
attribute." and then a little later it says, "The resource {url} was
preloaded using link preload but not used within a few seconds from
the window's load event. Please make sure it has an appropriate `as`
value and it is preloaded intentionally." Removing the crossorigin
attribute on the font links removed the preload warning and it looks
like everything is preloading correctly to me in dev/production (fonts
load at the very beginning and no warnings). Maybe if CORS is not used
then it also doesn't want crossorigin attribute.
leblowl
added a commit
that referenced
this pull request
Jan 18, 2024
On desktop, the browser was emitting several errors/warnings that
filled up the console. Some of these were related to React and then
some of them related to HTML preload. The preload warning says, "A
preload for {url} is found, but is not used because the request
credentials mode does not match. Consider taking a look at crossorigin
attribute." and then a little later it says, "The resource {url} was
preloaded using link preload but not used within a few seconds from
the window's load event. Please make sure it has an appropriate `as`
value and it is preloaded intentionally." Removing the crossorigin
attribute on the font links removed the preload warning and it looks
like everything is preloading correctly to me in dev/production (fonts
load at the very beginning and no warnings). Maybe if CORS is not used
then it also doesn't want crossorigin attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On desktop, the browser was emitting several errors/warnings that filled up the console. Some of these were related to React and then some of them related to HTML preload. The preload warning says, "A preload for {url} is found, but is not used because the request credentials mode does not match. Consider taking a look at crossorigin attribute." and then a little later it says, "The resource {url} was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate
asvalue and it is preloaded intentionally." Removing the crossorigin attribute on the font links removed the preload warning and it looks like everything is preloading correctly to me in dev/production (fonts load at the very beginning and no warnings). Maybe if CORS is not used then it also doesn't want crossorigin attribute.Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: