Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write :smile: for 😄, :tada: for 🎉, :rocket: for 🚀 #540 #1822

Closed
wants to merge 1 commit into from

Conversation

pdurbin
Copy link
Contributor

@pdurbin pdurbin commented Sep 17, 2023

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

This is just a draft pull request for now. @holmesworcester and I were talking about it.

It's for this issue:

So far I'm only supporting three emoji codes (smile, tada, and rocket). And there's no preview, no picker. I was just happy to get something working. 😅

Here are a couple screenshots:

Screenshot 2023-09-16 at 11 00 15 PM Screenshot 2023-09-16 at 11 00 21 PM

@pdurbin pdurbin changed the title write 😄 for 😄, 🎉 for 🎉, rocket for 🚀 #540 write :smile: for 😄, :tada: for 🎉, :rocket: for 🚀 #540 Sep 17, 2023
@holmesworcester
Copy link
Contributor

holmesworcester commented Sep 17, 2023

Looks great! I think if we had a complete emojimap and a couple tests this would be good to go.

@pdurbin
Copy link
Contributor Author

pdurbin commented Sep 17, 2023

Ha. Thanks. Just hacking for fun. 😜

For the complete emojimap, we should probably tap in to our existing emoji library, right? It looks like @siepra added https://www.npmjs.com/package/emoji-picker-react in 654b315. I see the data I want over at https://github.com/ealush/emoji-picker-react/blob/4.0.0/src/data/emojis.json for example. In GitHub I type :sweat_smile: to get 😅 and that JSON file has pretty much the same, but with spaces instead of underscores and no colons...

{
  "n": [
    "sweat smile",
    "smiling face with open mouth and cold sweat"
  ],
  "u": "1f605",
  "a": "0.6"
},

... but we can probably work with that. From the emoji-picker-react docs I'm not sure how to get at the data. I'm not sure where to pass in sweat smile to get the emoji I want, I mean. This issue suggests that maybe the data needs to be exported:

Does that sound right?

Also, where should I add tests, please?

Finally, two tests are failing in this PR:

  • Check / check (ubuntu-20.04) (pull_request)
  • Visual regressions / chromatic-deployment (ubuntu-20.04) (pull_request)

Is this expected for outside contributors? Thanks!

@holmesworcester
Copy link
Contributor

I would be okay with duplicating the data by hand if that's the best solution.

Another thing we could do is look at how matternost solves this problem. There might be another library that is useful.

@pdurbin
Copy link
Contributor Author

pdurbin commented Oct 11, 2023

I'm not actively working on this so I'm going to close this pull request to reduce noise and clutter. Maybe a future developer and at least see which files need to be touched by looking at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants