Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating channel naming logic #2307

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Conversation

richardtorres314
Copy link
Contributor

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

Screenshots

Before

Before

After

After

@leblowl
Copy link
Collaborator

leblowl commented Feb 20, 2024

Thanks @richardtorres314. It looks like a few tests fail. And then I was thinking about the case of channel names Test and test. It looks like we probably want our channel/username comparison to be case insensitive, so Test === test and it looks like it was previously. I think just adding the toLowerCase() back in there should resolve that.

@richardtorres314 richardtorres314 changed the title closes #2299 Updating channel naming logic Feb 21, 2024
@richardtorres314 richardtorres314 marked this pull request as draft February 23, 2024 16:54
@richardtorres314
Copy link
Contributor Author

@leblowl I've updated a few of the tests but still have some outstanding failing tests I can't seem to resolve. I also can't seem to build the desktop app to test due to an error that seems to have been introduced a few days ago (error message: Uncaught Error: You must pass a selector to useSelector). I'll update this PR when I can rebase off of develop and building is resolved.

@holmesworcester
Copy link
Contributor

@leblowl @EmiM can you reproduce develop being broken?

@richardtorres314 can you add any information about your system to help us reproduce the problem if we cannot?

@richardtorres314
Copy link
Contributor Author

@holmesworcester I just found my problem, I switched node environments when working on a different project and failed to revert environments when returning to the project. I can confirm upon switching that all errors have been removed and the app works as expected.

I'll continue working on the tests today. Thank you!

@richardtorres314 richardtorres314 marked this pull request as ready for review March 6, 2024 18:23
Copy link
Collaborator

@leblowl leblowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leblowl leblowl merged commit 38b007e into TryQuiet:develop Mar 6, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants