-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating channel naming logic #2307
Conversation
Thanks @richardtorres314. It looks like a few tests fail. And then I was thinking about the case of channel names |
120553a
to
0cd049c
Compare
d2f50af
to
c997bd1
Compare
c997bd1
to
eaa95ef
Compare
@leblowl I've updated a few of the tests but still have some outstanding failing tests I can't seem to resolve. I also can't seem to build the desktop app to test due to an error that seems to have been introduced a few days ago (error message: |
@leblowl @EmiM can you reproduce develop being broken? @richardtorres314 can you add any information about your system to help us reproduce the problem if we cannot? |
@holmesworcester I just found my problem, I switched node environments when working on a different project and failed to revert environments when returning to the project. I can confirm upon switching that all errors have been removed and the app works as expected. I'll continue working on the tests today. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package:
Screenshots
Before
After