New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unit parsing #58

Merged

alexander-akait merged 1 commit into master from fix-unit-parsing

Aug 7, 2019

Collaborator

alexander-akait commented Aug 6, 2019 •

edited

Rewrite parser using algorithm from spec https://www.w3.org/TR/css-syntax-3/#consume-number, it is better maintenance than loop

Also we have some edge cases where parser return invalid result and try to fix it increase nested if/else


          fix: unit parsing

73b621f

TrySound approved these changes

View reviewed changes

alexander-akait merged commit d83cd7f into master

alexander-akait deleted the fix-unit-parsing branch

August 7, 2019 18:03

illogic-al mentioned this pull request

[Bug] : grid-name e1 -> NaN cssnano/cssnano#984

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment