Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terser dependency #61

Open
DillonSadofsky opened this issue Mar 4, 2022 · 0 comments
Open

Update terser dependency #61

DillonSadofsky opened this issue Mar 4, 2022 · 0 comments

Comments

@DillonSadofsky
Copy link

We are using this plugin plus the rollup-terser-plugin in a couple projects, and in a newer one we started targeting a newer version of ECMA in the output, which lead to some more modern JS features remaining in the js during transpile (for example optional chaining). This choked up rollup-plugin-terser, but updating it fixed it. However, when I use rollup-plugin-size-snapshot, it dies on line 80 because of line 68:

      const minified = (0, _terser.minify)(source).code;

returns undefined due to modern ECMA symbols breaking the version of the terser included as a dependency:
image

If it doesn't break anything, it'd be nice to see the terser as a peer dependency or just updated to support modern js features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant